Help defining Facts and Dimensions for a General Ledger Transaction Table

Hi,

I need some help delineating some of the facts from dimensions for a General Ledger Transaction datamart. I already have a GL Organization, Date, Account, Activity, and Account Category dimension that the GL Fact table would be joined to. But I need to seperate some trnsactional data into dimensions to get the fact table to be thin.
Below is a breakout:
In the Fact Table I would just have GLAmount and GLUnits and the foriegn keys for the tables. Credits would just be negative amounts.
Degenerate Dimensions would be JE Number and Line Number and create date which would also be housed in the fact table.
Junk Dimension for JE Sequence, Auto Reverse Flag, Negative Adj Flag.
JE Type Dimension would include System code, JE Type, Reference, Originating Comapny, Program, Operator.
JE Description would be it's own Dimension.
All fields would be in the staging table to get the keys.

Could you provide some insight as to my choices. I feel like somthing's off in this design. Any advice would be greatly appreciated.

Thanks,

Peter Brayton.