Contract Terms dimension per ETL toolkit - populating the dimension

Contract Terms dimension per ETL toolkit - populating the dimension

In the ETL Toolkit, for Procurement- a contract terms dimension is mentioned...
Contrat Terms Dimension..

Contract Terms Key (PK)
Contract Terms Description
Contract Terms Type

The contract terms dimension contains one row for each generalized set of negotiated
terms, similar to the promotion dimension...

In our case, we have a bonus flag on a contract that has a value of 0 or 1

I assume we would create 2 rows one for Bonus + 0 state and one for Bonus +1 state

In another case - similar we have a third party voucher flag 0 or 1 state

In another case we have a Min_Config amount of X >>> so this would be one row with amount...

Does this sound like the proper approach to populate the dimension?